Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements a project-wide rebranding from Genesis Core to Exordos Core, updating source code, documentation, and configuration files. The review identifies several missed renames and inconsistencies, specifically regarding domain URLs, repository links, internal hostnames, certificate subjects, and OIDC client metadata. A typo introduced during the find-and-replace process in the documentation was also flagged for correction.
|  | ||
|  |
There was a problem hiding this comment.
There's an inconsistency in URL updates. While GitHub repository links have been updated from genesis_core to exordos_core, several other URLs pointing to domains like repository.genesis-core.tech and genesis-core.tech have not been changed throughout the project. For a complete rename, these should also be updated if new domains are available.
References
- Ensure code examples and comments in documentation accurately reflect the actual implementation, such as API endpoint URLs.
| - Genesis SDK is a set of tools for developing Genesis elements. You can find it [here](https://github.com/infraguys/gcl_sdk). | ||
| - Genesis DevTools it's a set oftools to manager life cycle of genesis projects. You can find it [here](https://github.com/infraguys/genesis_devtools). | ||
| - Exordos SDK is a set of tools for developing Exordos elements. You can find it [here](https://github.com/infraguys/gcl_sdk). | ||
| - Exordos DevTools it's a set oftools to manager life cycle of genesis projects. You can find it [here](https://github.com/infraguys/genesis_devtools). |
There was a problem hiding this comment.
This line has a couple of inconsistencies from the rename:
- The phrase 'genesis projects' should be 'exordos projects'.
- The URL points to a repository named genesis_devtools, which is inconsistent with the Exordos DevTools name.
References
- Ensure code examples and comments in documentation accurately reflect the actual implementation, such as API endpoint URLs.
| from genesis_core.compute.dm import models | ||
| from exordos_core.compute.dm import models | ||
|
|
||
| LOCAL_GC_HOST = "core.local.genesis-core.tech" |
There was a problem hiding this comment.
This internal hostname still contains genesis-core. For consistency, it should be updated to core.local.exordos-core.tech.
| LOCAL_GC_HOST = "core.local.genesis-core.tech" | |
| LOCAL_GC_HOST = "core.local.exordos-core.tech" |
| @@ -360,7 +360,7 @@ def upgrade(self, session): | |||
| ) VALUES( | |||
| '00000000-0000-0000-0000-000000000000', | |||
| 'GenesisCoreClient', | |||
| 'Genesis Core OIDC Client', | |||
| 'Exordos Core OIDC Client', | |||
There was a problem hiding this comment.
While the client description on this line has been updated, the client name on line 362 (GenesisCoreClient) and client ID on line 364 (GenesisCoreClientId) have not. This is inconsistent and should be addressed to complete the rename.
043bf41 to
9b6193b
Compare
3 participants
What was renamed:
What was NOT renamed yet:
Migration: